[PATCH] D67135: [clang-tidy] performance-inefficient-vector-operation: Support proto repeated field

Cong Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 4 13:43:33 PDT 2019


congliu added a comment.

In D67135#1657034 <https://reviews.llvm.org/D67135#1657034>, @lebedev.ri wrote:

> I'm not sure this is the correct approach.
>  I'd think the check instead should be parametrized, so this patch should become just extending the config.


Could you elaborate how the parameterized check will look like? By `config` did you mean the check options?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67135/new/

https://reviews.llvm.org/D67135





More information about the cfe-commits mailing list