[PATCH] D67080: [clang-tidy] Fix bugprone-argument-comment bug if there are marcos.

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 4 06:54:10 PDT 2019


alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.

LG. Thanks!



================
Comment at: clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp:326
+      CharSourceRange ArgsRange =
+          MakeFileCharRange(Args[I]->getBeginLoc(), Args[I]->getEndLoc());
       Comments = getCommentsBeforeLoc(Ctx, ArgsRange.getBegin());
----------------
I don't know what motivation was to try parsing to the end of the arguments.  But since no tests break, it should be fine to change.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67080/new/

https://reviews.llvm.org/D67080





More information about the cfe-commits mailing list