[PATCH] D66988: [NewPM][Sancov] Make Sancov a Module Pass instead of 2 Passes

Chandler Carruth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 3 23:07:01 PDT 2019


chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

LGTM

This also makes sense to me why it would OOM. I suspect we're building a massive list, and at best we get lucky and they get de-duped later. At worst, this is actually fixing a serious functionality problem. We had the same thing w/ normal ASan before too. Since this pass doesn't need to be a function pass anyways, this seems totally fine. Thanks for tracking it down.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66988/new/

https://reviews.llvm.org/D66988





More information about the cfe-commits mailing list