[PATCH] D64672: [X86] Prevent passing vectors of __int128 as <X x i128> in llvm IR

Simon Pilgrim via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 2 14:25:10 PDT 2019


RKSimon added a comment.

In D64672#1654983 <https://reviews.llvm.org/D64672#1654983>, @craig.topper wrote:

> In D64672#1654687 <https://reviews.llvm.org/D64672#1654687>, @RKSimon wrote:
>
> > Tests look great - please can you pre-commit them and update the patch to show the diff? Also, maybe call the test file x86-vec-i128.c and add a comment in the file describing PR42607?
>
>
> How do you want me to show the diff? There a couple options. Three of the check lines have to be removed from the pre-commit since they use a command line option that doesn't exist. Do you want me to change the check lines that say NEWABI to use the old code? Or do you want me to manipulate the FileCheck command lines to use the OLDABI check lines?


How about CLANG9ABI and CLANG10ABI? And the patch just adds the -fclang-abi-compat=9 tests?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64672/new/

https://reviews.llvm.org/D64672





More information about the cfe-commits mailing list