[PATCH] D67077: [libclang] Refactored SharedParsedRegionsStorage

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 2 05:54:18 PDT 2019


gribozavr created this revision.
Herald added subscribers: cfe-commits, arphaman.
Herald added a project: clang.
gribozavr added a reviewer: jkorous.
Herald added a subscriber: dexonsmith.

Removed the `PPRegionSetTy` typedef because it is only used 3 times, and
obscures code more than it helps.

Renamed SharedParsedRegionsStorage to ThreadSafeParsedRegions, because
that better reflects the reason for this type to exist.

Replaced the `copyTo()` method that had an out parameter with a getter.

Renamed the `merge()` method to `addParsedRegions()`.

Renamed `ParsedSrcLocationsTracker::ParsedRegions` to
`ParsedRegionsSnapshot`, which better reflects its role.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D67077

Files:
  clang/tools/libclang/Indexing.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67077.218346.patch
Type: text/x-patch
Size: 4298 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190902/57300c4e/attachment.bin>


More information about the cfe-commits mailing list