[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 30 10:28:52 PDT 2019


ABataev added inline comments.


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:5423
+		SemaRef.Diag(DefaultLoc, diag::err_omp_loop_not_canonical_cond)
+			<< IneqCondIsCanonical << LCDecl;
     return true;
----------------
I would not suggest to rely on the conversion of bool values to integer, better to use `IneqCondIsCanonical ? 0 : 1`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66559/new/

https://reviews.llvm.org/D66559





More information about the cfe-commits mailing list