[PATCH] D66960: [Tooling] Migrated APIs that take ownership of objects to unique_ptr

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 30 02:20:12 PDT 2019


gribozavr added a comment.

In D66960#1651258 <https://reviews.llvm.org/D66960#1651258>, @lebedev.ri wrote:

> In D66960#1651243 <https://reviews.llvm.org/D66960#1651243>, @gribozavr wrote:
>
> > In D66960#1651198 <https://reviews.llvm.org/D66960#1651198>, @lebedev.ri wrote:
> >
> > > This is missing documentation changes.
> >
> >
> > Could you point out such places? I tried to remove "takes ownership" comments which became redundant.
>
>
> See my two original patches.


Thanks, fixed docs.

>>> And this likely would be good to mention in releasenotes.
>> 
>> Will add.

Added release notes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66960/new/

https://reviews.llvm.org/D66960





More information about the cfe-commits mailing list