[PATCH] D66862: Make lround builtin constexpr (and others)

Craig Topper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 29 14:41:26 PDT 2019


craig.topper added inline comments.


================
Comment at: clang/lib/AST/ExprConstant.cpp:9620
+
+    if(!EvaluateFloat(E->getArg(0), FPVal, Info)) return false;
+    APFloat::opStatus status =
----------------
Space after if


================
Comment at: clang/lib/AST/ExprConstant.cpp:9623
+        FPVal.convertToInteger(IVal, APFloat::rmNearestTiesToAway, &isExact);
+    if(status != APFloat::opInexact && status != APFloat::opOK) return false;
+
----------------
Space after if


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66862/new/

https://reviews.llvm.org/D66862





More information about the cfe-commits mailing list