[clang-tools-extra] r370372 - [Clangd] NFC: Added fixme for checking for local/anonymous types for extracted parameters

Shaurya Gupta via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 29 08:12:00 PDT 2019


Author: sureyeaah
Date: Thu Aug 29 08:11:59 2019
New Revision: 370372

URL: http://llvm.org/viewvc/llvm-project?rev=370372&view=rev
Log:
[Clangd] NFC: Added fixme for checking for local/anonymous types for extracted parameters

Modified:
    clang-tools-extra/trunk/clangd/refactor/tweaks/ExtractFunction.cpp

Modified: clang-tools-extra/trunk/clangd/refactor/tweaks/ExtractFunction.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clangd/refactor/tweaks/ExtractFunction.cpp?rev=370372&r1=370371&r2=370372&view=diff
==============================================================================
--- clang-tools-extra/trunk/clangd/refactor/tweaks/ExtractFunction.cpp (original)
+++ clang-tools-extra/trunk/clangd/refactor/tweaks/ExtractFunction.cpp Thu Aug 29 08:11:59 2019
@@ -459,6 +459,7 @@ CapturedZoneInfo captureZoneInfo(const E
 // Adds parameters to ExtractedFunc.
 // Returns true if able to find the parameters successfully and no hoisting
 // needed.
+// FIXME: Check if the declaration has a local/anonymous type
 bool createParameters(NewFunction &ExtractedFunc,
                       const CapturedZoneInfo &CapturedInfo) {
   for (const auto &KeyVal : CapturedInfo.DeclInfoMap) {




More information about the cfe-commits mailing list