[PATCH] D66928: [clangd] Collecting main file macro expansion locations in ParsedAST.

[Johan Vikström via Phabricator via cfe-commits]

jvikstrom marked an inline comment as done.
jvikstrom added inline comments.


================
Comment at: clang-tools-extra/clangd/ClangdUnit.cpp:107
 
+class CollectMainFileMacroExpansions : public PPCallbacks {
+  const SourceManager &SM;
----------------
ilya-biryukov wrote:
> Maybe make this part of `CollectMainFileMacros`? It looks like a natural fit there and we won't need another instance of `PPCallbacks`.
But `CollectMainFileMacros` is only used for `buildPreamble`. 
I think this one needs to run in `ParsedAST::build`?

Is it safe to add a `CollectMainFileMacros in `ParsedAST::build`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66928/new/

https://reviews.llvm.org/D66928