[PATCH] D66878: [Index] Stopped wrapping FrontendActions in libIndex and its users

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov accepted this revision.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: clang-tools-extra/clangd/index/IndexAction.cpp:217
   std::unique_ptr<CanonicalIncludes> Includes;
+  index::IndexingOptions Opts;
   std::unique_ptr<CommentHandler> PragmaHandler;
----------------
gribozavr wrote:
> ilya-biryukov wrote:
> > Are these option ever used? Do we need to keep them alive for the lifetime of the action?
> > Might be worth a comment.
> They are passed in through the constructor, and consumed by `index::createIndexingASTConsumer` in `CreateASTConsumer`. So they need to be stored in a member variable between those two calls.
Ah, missed that at first glance. Thanks for the explanation, LG.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66878/new/

https://reviews.llvm.org/D66878