[PATCH] D66876: Indexing: create PP callbacks in the ASTConsumer

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 28 06:30:25 PDT 2019


gribozavr created this revision.
Herald added subscribers: cfe-commits, arphaman.
Herald added a project: clang.
gribozavr added a parent revision: D66875: [Index] Marked a bunch of classes 'final'.

Doing so removes one reason to create a custom FrontendAction.
FrontendActions are not desirable because they are difficult to compose.
ASTConsumers are much easier to compose.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D66876

Files:
  clang/lib/Index/IndexingAction.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66876.217623.patch
Type: text/x-patch
Size: 4795 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190828/3665a2d2/attachment.bin>


More information about the cfe-commits mailing list