[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

Sergey Dmitriev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 27 11:31:35 PDT 2019


sdmitriev marked an inline comment as done.
sdmitriev added inline comments.


================
Comment at: clang/test/Driver/clang-offload-bundler.c:228-231
+// Check that we can extract target parts without providing host triple.
+// RUN: clang-offload-bundler -type=ast -targets=openmp-powerpc64le-ibm-linux-gnu -outputs=%t.res.tgt1 -inputs=%t.bundle3.unordered.ast -unbundle
+// RUN: diff %t.tgt1 %t.res.tgt1
+
----------------
ABataev wrote:
> What about tests for other kinds of elements like preprocessed code, IR, objects, etc.?
Ok, I can add more tests for reprocessed code, IR, etc. I have added one test per file handler type so far, but I can do it per file type. BTW, test for object type is already there on line 264.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66601/new/

https://reviews.llvm.org/D66601





More information about the cfe-commits mailing list