[clang-tools-extra] r369915 - [clang-tidy][NFC] Qualify `makeRule` call in test, for consistency with other calls.

Yitzhak Mandelbaum via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 26 08:27:05 PDT 2019


Author: ymandel
Date: Mon Aug 26 08:27:05 2019
New Revision: 369915

URL: http://llvm.org/viewvc/llvm-project?rev=369915&view=rev
Log:
[clang-tidy][NFC] Qualify `makeRule` call in test, for consistency with other calls.

One call `makeRule` is unqualified (and unintentionally relying on ADL to
resolve correctly). This revision qualifies that call for consistency and to
drop use of ADL.

Modified:
    clang-tools-extra/trunk/unittests/clang-tidy/TransformerClangTidyCheckTest.cpp

Modified: clang-tools-extra/trunk/unittests/clang-tidy/TransformerClangTidyCheckTest.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/unittests/clang-tidy/TransformerClangTidyCheckTest.cpp?rev=369915&r1=369914&r2=369915&view=diff
==============================================================================
--- clang-tools-extra/trunk/unittests/clang-tidy/TransformerClangTidyCheckTest.cpp (original)
+++ clang-tools-extra/trunk/unittests/clang-tidy/TransformerClangTidyCheckTest.cpp Mon Aug 26 08:27:05 2019
@@ -174,8 +174,9 @@ TEST(TransformerClangTidyCheckTest, Disa
 
 RewriteRule replaceCall(IncludeFormat Format) {
   using namespace ::clang::ast_matchers;
-  RewriteRule Rule = makeRule(callExpr(callee(functionDecl(hasName("f")))),
-                              change(text("other()")), text("no message"));
+  RewriteRule Rule =
+      tooling::makeRule(callExpr(callee(functionDecl(hasName("f")))),
+                        change(text("other()")), text("no message"));
   addInclude(Rule, "clang/OtherLib.h", Format);
   return Rule;
 }




More information about the cfe-commits mailing list