[PATCH] D66705: FileManager: Use llvm::Expected in new getFileRef API

Sat Aug 24 08:32:01 PDT 2019

arphaman added inline comments.

================
Comment at: clang/lib/Lex/HeaderSearch.cpp:1079
   if (!File) {
     // Check ".../Frameworks/HIToolbox.framework/PrivateHeaders/HIToolbox.h"
     HeadersFilename = FrameworkName;
----------------
It should be fine to update the return type, but I believe that `Expected` will cause an assertion as the error is unhandled in cases like this one. Can you verify that all errors are consumed somehow?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66705/new/

https://reviews.llvm.org/D66705