[PATCH] D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467)

[Roman Lebedev via Phabricator via cfe-commits]

lebedev.ri added inline comments.


================
Comment at: clang/lib/Sema/SemaChecking.cpp:8100-8107
+        // All further checking is done on the subexpression
+        Match = AT.matchesType(S.Context, ExprTy);
+        if (Match) {
+          if (Match == analyze_printf::ArgType::NoMatchPedantic)
+            Pedantic = true;
+          else
+            return true;
----------------
lebedev.ri wrote:
> Just add a new variable
> ```
> // All further checking is done on the subexpression
> analyze_printf::ArgType::MatchKind Match2 = AT.matchesType(S.Context, ExprTy);
> if (Match2 == analyze_printf::ArgType::Match)
>   return true;
> Pedantic |= Match2 == analyze_printf::ArgType::NoMatchPedantic;
> ```
Early return would simplify this still


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66186/new/

https://reviews.llvm.org/D66186