[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

Dávid Bolvanský via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 19 11:45:00 PDT 2019


xbolva00 added a comment.

I think it is too soon to jump and disable all macros. We still catch all motivating cases, it found bugs in Chromium.

Chromium's case makes sense but on the other hand, LHS does not make much sense to be a macro. #define TWO 2  and res =   TWO ^ 32? And even for this case, I think the user should rework it to #define TWO 0x2.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66397/new/

https://reviews.llvm.org/D66397





More information about the cfe-commits mailing list