[PATCH] D66332: [clang-format] Fix the bug that joins template closer and > or >>

Owen Pan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 16 14:47:09 PDT 2019

owenpan added a comment.

In D66332#1633448 <https://reviews.llvm.org/D66332#1633448>, @Quuxplusone wrote:

> Drive-by observation: My experiments with https://zed0.co.uk/clang-format-configurator/ show that there is a similar bug where clang-format accidentally produces `>=` via reformatting of `template<enable_if_t<Foo, int>` `=0>`, `pi<int>` `=3;`, and so on. Is it possible to fix that bug as part of this patch, and/or would you be interested in patching that bug as a follow-up to this one?

Do you have `SpaceBeforeAssignmentOperators` off? I am more than happy to fix it as a follow-up, but the current behavior of `SpaceBeforeAssignmentOperators` is:

  int a = 5;
  a += 42;


  int a= 5;
  a+= 42;

It's weird that there is a space after the assignment operators regardless.

The documentation <https://clang.llvm.org/docs/ClangFormatStyleOptions.html#configurable-format-style-options> should be fixed.

  rC Clang



More information about the cfe-commits mailing list