[PATCH] D66333: [analyzer] NonNullParamChecker and CStringChecker parameter number in checker message
Whisperity via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Aug 16 05:22:37 PDT 2019
whisperity added inline comments.
Comment at: clang/lib/StaticAnalyzer/Checkers/NonNullParamChecker.cpp:195-196
+ llvm::raw_svector_ostream OS(SBuf);
+ OS << "Null pointer passed as an argument to a 'nonnull' ";
+ OS << Idx << llvm::getOrdinalSuffix(Idx) << " parameter";
It seems to be as if now you're able to present which parameter is the `[[nonnull]]` one. Because of this, the output to the user sounds really bad and unfriendly, at least to me.
How about this:
"null pointer passed to nth parameter, but it's marked 'nonnull'"?
"null pointer passed to nth parameter expecting 'nonnull'"?
Something along these lines.
To a parameter, we're always passing arguments, so saying "as an argument" seems redundant.
And because we have the index always in our hands, we don't need to use the indefinite article.
CHANGES SINCE LAST ACTION
More information about the cfe-commits