[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

Csaba Dabis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 15 16:10:00 PDT 2019

Charusso marked an inline comment as done.
Charusso added a comment.

@Szelethus pointed out well. My patch is about nullability, and it is perfect. The bug report you made is about deduplication rather than nullability. The fact is we fail to call the deduplication function: `eventsDescribeSameCondition()` from `removeRedundantMsgs(PathPieces &path)` because the `path` does not contain the path pieces. We call `removeRedundantMsgs` with passing the `PD->getMutablePieces()`, but this only contains one piece of the top-level function call in the test case you have attached.

I would upstream my hotfix of nullability without any tests as the comment says the intention and also we have plenty of tests of `TrackConstraintBRVisitor`, none of them changed.

  rC Clang



More information about the cfe-commits mailing list