[PATCH] D65997: Add options rounding and exceptions to pragma fp

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 15 06:28:42 PDT 2019


aaron.ballman added inline comments.


================
Comment at: clang/lib/Parse/ParsePragma.cpp:2678
 
+  auto *AnnotValue = new (PP.getPreprocessorAllocator()) TokFPAnnotValue;
   while (Tok.is(tok::identifier)) {
----------------
sepavloff wrote:
> aaron.ballman wrote:
> > Might as well move this down to around line 2710, closer to where it's used. This way we don't allocate something only to ignore it due to errors in fewer situations.
> Actually it cannot be closer. It is created just before the loop, in which fields of `*AnnotValue` are read.
Ah, you're right, I didn't see that was inside the loop itself. Nevermind. :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65997/new/

https://reviews.llvm.org/D65997





More information about the cfe-commits mailing list