[PATCH] D52524: Add -Wno-poison-system-directories flag

Manoj Gupta via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 14 19:59:39 PDT 2019

manojgupta added a comment.

In D52524#1630767 <https://reviews.llvm.org/D52524#1630767>, @thakis wrote:

> Wouldn't those projects just move to also disabling the warning by passing -Wno-poison-system-directories? If there are projects that are actively adding -I/usr/include, that means they're consciously fighting the build system and you've kind of already lost, no? Can't you tell them to not use -I/usr/include?

Most of the time, those packages are not exactly fighting cross-compilation (e.g. samba), just they just have a broken build system that adds I/usr/include when building them. This warning will help catch bad includes whenever someone imports a new package or upgrade to a newer version from upstream.
Note: in Chrome OS, packages are built using their native build system e.g. LLVM is built with cmake, tensorflow is built with bazel etc.



More information about the cfe-commits mailing list