[PATCH] D66247: [OpenMP] Fix target map for unused variables
Alexey Bataev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 14 14:50:41 PDT 2019
ABataev added a comment.
In D66247#1630333 <https://reviews.llvm.org/D66247#1630333>, @jdenny wrote:
> In D66247#1630321 <https://reviews.llvm.org/D66247#1630321>, @ABataev wrote:
> > Try `map(a) firstprivate(a) defaultmap(scalar:tofrom)`, where `a` is `int`, for example. The variable must be mapped as `tofrom` in this case but, most probably, will be mapped as `to`.
> Map type is 35=0x23, which has tofrom.
Yes, just realized that, defaultmap does not affect explicit firstprivates. Then just check `map(a) firstprivate(a)` for `int128` type. Check that it still has `tofrom` mapping. If so, then probably we already can handle such combinations correctly in the codegen. Also, test it for other mapping types, like alloc, from, to.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits