[PATCH] D66254: Correct include suggestion when search path includes symlink
Ben Jackson via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 14 14:21:46 PDT 2019
puremourning added a comment.
In D66254#1630283 <https://reviews.llvm.org/D66254#1630283>, @puremourning wrote:
> In D66254#1630277 <https://reviews.llvm.org/D66254#1630277>, @lebedev.ri wrote:
> > Tests?
> Per my comment: I haven't added new tests to HeaderSearchTest.cc because the InMemoryFileSystem doesn't support symlinks and I didn't want to try and implement that for this patch. Let me know thoughts on alternative ways to regression test it.
OK I found test/SemaCXX/missing-header
Might be able to use the _real_ filesystem and go via the diagnostic rather than clangd
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits