[PATCH] D65997: Add options rounding and exceptions to pragma fp

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

This generally LGTM, but there are open questions on https://reviews.llvm.org/D66092#1625380 that I think need to be answered before this should be committed.



================
Comment at: clang/lib/Parse/ParsePragma.cpp:2678
 
+  auto *AnnotValue = new (PP.getPreprocessorAllocator()) TokFPAnnotValue;
   while (Tok.is(tok::identifier)) {
----------------
Might as well move this down to around line 2710, closer to where it's used. This way we don't allocate something only to ignore it due to errors in fewer situations.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65997/new/

https://reviews.llvm.org/D65997