[PATCH] D65250: [analyzer] exploded-graph-rewriter: Improve user-friendliness.
Artem Dergachev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 13 16:01:08 PDT 2019
NoQ marked 2 inline comments as done.
NoQ added inline comments.
Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:846
+ print(' $ dot -Tsvg input.dot -o output.svg')
+ write_temp_file('.dot', self.output())
> Why we need multiple prints to print one message? According to the Stack Overflow:
> Link: https://stackoverflow.com/questions/34980251/how-to-print-multiple-lines-of-text-with-python
I dislike what it does to my formatting. We're in 4 nested scopes and it suddenly requires me to make an un-indented block.
Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:953
+ 'displaying it, dump the rewritten dot file '
+ 'to stdout')
args = parser.parse_args()
> This flag is a little-bit too long and does not really emphasize what it suppose to do. What about just `--dump` or `--stdout`?
Renamed to `--dump-dot-only`.
CHANGES SINCE LAST ACTION
More information about the cfe-commits