[PATCH] D65484: [analyzer][NFC] Refactoring BugReporter.cpp P5.: Compact mile long function invocations into objects

Kristóf Umann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 13 13:42:32 PDT 2019

Szelethus closed this revision.
Szelethus marked 5 inline comments as done.
Szelethus added a comment.

The deed is done.

Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:111
+/// getters and some well placed asserts for extra security.
+class BugReportConstruct {
+  /// The consumer we're constructing the bug report for.
Szelethus wrote:
> NoQ wrote:
> > You mean `Construct` like a noun? Not sure what that means.
> > 
> > Maybe `PathDiagnosticContext`?
> Yea, I originally wanted to have the class name `BaconStrip` so that it screams just a bit louder that I couldnt come up with anything good, but maybe `PathDiagnosticConstruction` or something like that would be better.
Mmmmm this entire class is about non-contextual stuff, I'd rather stick with `PathDiagnosticConstruct` and just explain it well in the comments.

Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:140
+  /// bug path.
+  const LocationContext *getCurrLocationContext() const {
+    assert(CurrentNode && "Already reached the root!");
NoQ wrote:
> > Curr
> Purr? =^.^=
I've always been a cat person. They take care of themselves, just like a good C++ class should :^)




More information about the cfe-commits mailing list