[PATCH] D66058: [NFC][clang] Move much of the argument handling code from Driver::BuildActions to Driver::handleArguments.

Puyan Lotfi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 13 11:45:51 PDT 2019

plotfi marked an inline comment as done.
plotfi added inline comments.

Comment at: clang/include/clang/Driver/Driver.h:264
+                       const InputList &Inputs, ActionList &Actions,
+                       llvm::opt::Arg *YcArg, llvm::opt::Arg *YuArg) const;
aaron.ballman wrote:
> I think the presence of the `YcArg` and `YuArg` parameters needs some explanation in the comments, as those seem rather out of place.
Those are the only corner case as far as things used and modified in the scope. Was just trying to preserve the existing behavior. I think those two args are used for clang-cl and the code that handles them just sets them to nullptr. I can add a comment trying to explain what is happening here. There were some tests that I remember were failing if those args weren't set to nullptr after being used. 

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list