[PATCH] D66121: Debug Info: Nest Objective-C property function decls inside their container.

Vedant Kumar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 12 16:56:13 PDT 2019


vsk added a comment.

Looks reasonable to me.



================
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3457
+  // the interface type.
+  if (const auto *OMD = dyn_cast_or_null<ObjCMethodDecl>(D)) {
+    auto *ID = dyn_cast_or_null<ObjCInterfaceDecl>(CD);
----------------
Return early on '! dyn_cast<ObjCMethodDecl>'? It doesn't look like 'D' may be null.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66121/new/

https://reviews.llvm.org/D66121





More information about the cfe-commits mailing list