[PATCH] D66068: cmake: Make building clang-shlib optional
Jan Vesely via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 12 16:36:23 PDT 2019
jvesely added a comment.
In D66068#1625995 <https://reviews.llvm.org/D66068#1625995>, @beanz wrote:
> I think you and I disagree here. General developer workflows don't need to include building `all` for every minor change. In my normal workflow I just re-run `check-llvm` or `check-clang` over and over again, only building the `all` target before I post a patch. With that workflow I only build the library once per-patch to ensure that it builds. Which is exactly the goal of not having it be included.
That's your workflow. I need to run 'make install' because the modifications are used by an external project. If there's an option to skip shlib during 'make install' I'd be happy to use it.
> If you *really* *really* can't be bothered to ensure that the things we ship actually build with your change you can always use the (undocumented, and hidden) `CLANG_TOOL_CLANG_SHLIB_BUILD=Off` option. I really don't see a reason to add a user-facing option that we don't want people using.
I'm pretty sure more people would appreciate not installing large duplicate libraries, but if a hidden option will do, I'll update the patch.
CHANGES SINCE LAST ACTION
More information about the cfe-commits