[PATCH] D65877: [libTooling] In Transformer, generalize `applyFirst` to admit rules with incompatible matchers.
Yitzhak Mandelbaum via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 12 11:59:12 PDT 2019
ymandel marked an inline comment as done.
ymandel added a comment.
In D65877#1625616 <https://reviews.llvm.org/D65877#1625616>, @gribozavr wrote:
> I'd prefer we ban them completely, and let the user wrap them manually if they need to. While some users would appreciate the ergonomics, I think AST matchers are complicated even without us adding more implicit behavior on top.
Done. I came to the same conclusion once I started implementing. Less (magic) is more, in this case.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits