[PATCH] D65999: [ASTImporter] Import additional flags for functions.

Mon Aug 12 02:06:32 PDT 2019

balazske marked an inline comment as done.
balazske added inline comments.

================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:5239

+TEST_P(ASTImporterOptionSpecificTestBase, ImportOfDefaultImplicitFunctions) {
+  // Test that import of implicit functions works and the functions
----------------
balazske wrote:
> a_sidorin wrote:
> > balazske wrote:
> > > martong wrote:
> > > > I don't exactly see how this test is related.
> > > I do not remember exactly why this test was added but probably the problem is structural equivalence related: The flags are not imported correctly for the first time, and at the second import structural match fails and a new Decl is created instead of returning the existing one. This test fails if the change is not applied.
> > Should we consider isExplicitlyDefaulted() when computing structural equivalence?
> We may use `isExplicitlyDefaulted` and `isDeletedAsWritten` and `isVirtualAsWritten` but in another patch.
It can be good to add check for `isExplicitlyDefaulted` because it is a separate bit and not checked yet. Probably in another patch that has a test for this too.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65999/new/

https://reviews.llvm.org/D65999