[PATCH] D65776: [Clang] Pragma vectorize_predicate implies vectorize

Michael Kruse via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 6 15:23:56 PDT 2019


Meinersbur added a comment.

Looking at the similar situation of `unroll(enable)`/`unroll_count(4)`, `unroll_count` also does not set `llvm.loop.unroll.enable`, but it is handled by the LoopUnroll pass itself:

  bool ExplicitUnroll = PragmaCount > 0 || PragmaFullUnroll ||
                        PragmaEnableUnroll || UserUnrollCount;

(LoopUnrollPass.cpp line 770f)

I do not know whether/how "setting a transformation option implicitly enables the transformation" should be implemented, maybe we should discuss this. It is currently inconsistent. Also consider that non-Clang frontends and .ll files in the wild might also expect a specific behavior.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65776/new/

https://reviews.llvm.org/D65776





More information about the cfe-commits mailing list