[PATCH] D65637: [clangd] [WIP] Semantic highlighting prototype for the vscode extension.

[Haojian Wu via Phabricator via cfe-commits]

hokein added a comment.

In D65637#1613692 <https://reviews.llvm.org/D65637#1613692>, @nridge wrote:

> Do you plan to support text decoration options other than color, e.g. bold / underline / italic?


I think we'd just support color, and we don't have further plan to support richer renderings at the moment -- ideally, vscode should have built-in support for semantic highlighting if the proposal is accepted in LSP, this means this part of extension code will be removed in the end.

> Are users going to be able to change the color (and other decoration options) for specific highlightings in the VSCode Settings?

vscode seems to provide a mechanism to override the theme settings, like

  "editor.tokenColorCustomizations": {
          "[Visual Studio Dark]": {
              "textMateRules": [
                  {
                      "scope": "entity.name.type",
                      "settings": {
                          "foreground": "#FF0000",
                      }
                  }
              ]    
          }

I think our extension should respect it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65637/new/

https://reviews.llvm.org/D65637