[PATCH] D65545: Handle some fs::remove failures
Alex Brachet via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Aug 2 21:02:53 PDT 2019
abrachet added a comment.
> I haven't updated all ignored instances of fs::remove, I therefore can't mark it LLVM_NODISCARD for now.
I think I remember reading that casting a `[[nodiscard]]` functions return to void was broken on some compilers, ie still warns. You cast `fs::remove` to void a lot here which is a great way to show intent (I wish we mentioned this in the style guide) but if I'm not just making this up, it might not be worth the trouble to give `fs::remove` the nodiscard attribute. Maybe something to look into if you ever do this.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits