[PATCH] D65510: [clangd] Fix implicit template instatiations appearing as topLevelDecls.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 2 07:11:22 PDT 2019


hokein added a comment.

the change looks good to me, leave the final approval to Ilya as he knows more context.



================
Comment at: clang-tools-extra/clangd/unittests/ClangdUnitTests.cpp:116
+  auto AST = TU.build();
+  EXPECT_THAT(AST.getLocalTopLevelDecls(), ElementsAre(DeclNamed("f"), DeclNamed("s")));
+}
----------------
nit: clang-format, the length seems > 80 column.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65510/new/

https://reviews.llvm.org/D65510





More information about the cfe-commits mailing list