[PATCH] D65525: [clangd] Add new helpers to make tweak tests scale better. Convert most tests. NFC

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 2 01:39:13 PDT 2019


ilya-biryukov added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/TweakTesting.h:44
+    // Snippet is an expression.
+    Expression,
+  };
----------------
ilya-biryukov wrote:
> I wonder whether we could use `Function` and get rid of 'expression' mode completely? WDYT?
> One can easily turn an expression into a statement by adding a semicolon.
Unsent draft comments here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65525/new/

https://reviews.llvm.org/D65525





More information about the cfe-commits mailing list