[PATCH] D58531: [clang] Specify type of pthread_create builtin

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 1 16:37:50 PDT 2019

jdoerfert added a comment.

In D58531#1599209 <https://reviews.llvm.org/D58531#1599209>, @probinson wrote:

> We've started running into this too in building the PS4 system. +jdoerfert who added pthread_create to the builtin list.
> Looking at the patch, it seems straightforward enough although clearly needs clang-format-diff run over it.
>  I don't touch Clang that much so I'm reluctant to okay it myself.

@probinson Thanks for making me aware of this patch.

> A separate point is whether it makes sense to be emitting this warning in the first place for GE_Missing_type. I'd argue that, if we don't know the type of the builtin, we should never emit the warning

@jrtc27 I hope the immediate need for this is gone after D58091 <https://reviews.llvm.org/D58091> was finally committed? Given that I caused this mess I can take a look at the patch if you are still interested in it, are you?

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list