[PATCH] D65545: Handle some fs::remove failures
JF Bastien via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jul 31 15:29:19 PDT 2019
jfb created this revision.
jfb added reviewers: Bigcheese, bruno, arphaman, vsapsai.
Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, jkorous, hiraditya.
Herald added projects: clang, LLVM.
We have data showing that some modules builds fail in rare cases. We're therefore interested in handling sources of failure better, especially when it comes to modules. This patch takes us a small step closer to this by handling the return code of fs::remove in code that seems like it should. I haven't updated all ignored instances of fs::remove, I therefore can't mark it LLVM_NODISCARD for now.
This previous patch helps propagate errors: https://reviews.llvm.org/D63518
rG LLVM Github Monorepo
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 15878 bytes
Desc: not available
More information about the cfe-commits