[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jul 31 01:19:59 PDT 2019
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:408
} // namespace
> Could you also add a separate test that checks diffs when the number of lines is getting smaller (i.e. taking `NLines` into account)
I would expect this to be better handled outside `checkDiffedHighlights` to avoid over-generalizing this function. But up to you.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits