[PATCH] D65184: [Sema] Thread Safety Analysis: Fix negative capability's LockKind representation.
Ziang Wan via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jul 30 11:25:45 PDT 2019
ziangwan marked an inline comment as done.
ziangwan added inline comments.
Comment at: clang/test/SemaCXX/thread-safety-annotations.h:47
+// Enable thread safety attributes only with clang.
+// The attributes can be safely erased when compiling with other compilers.
+#if defined(__clang__) && (!defined(SWIG))
> ziangwan wrote:
> > nickdesaulniers wrote:
> > > Is this test suite run with other compilers? If not, I think we can remove the case?
> > Yeah, you are right. I just copied the header definitions from clang thread safety analysis doc.
> Why aren't you using the existing macros? The idea was to run the tests with both old and new terminology, and for the time being, I think we should maintain both.
There are already tests on existing macros. I want to introduce tests about the new macros as well.
CHANGES SINCE LAST ACTION
More information about the cfe-commits