[PATCH] D65387: [clangd] Add a callback mechanism for handling responses from client.

[Jan Korous via Phabricator via cfe-commits]

jkorous added a comment.

Hi @hokein,
Do you have any thoughts on how to handle situation when client registers callback but doesn't send a request with registered ID later?



================
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:317
+    std::lock_guard<std::mutex> Lock(ReplyCallbacksMutex);
+    ReplyCallbacks[StrID] = std::move(CB);
+  }
----------------
Should we care if there's already another callback registered for this `StrID`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65387/new/

https://reviews.llvm.org/D65387