[PATCH] D65263: [clangd] a prototype for triggering rename after extracting.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 30 08:15:17 PDT 2019

hokein added a comment.

In D65263#1601036 <https://reviews.llvm.org/D65263#1601036>, @ilya-biryukov wrote:

> If we are going down that path, could we consider to pre-selecting a name of the extract variable and its usage (using multi-select)?

I agree that doing rename after extraction is not an ideal approach (both correctness and latency), there should be other better ways to achieve this. 
However as a LSP server, we may want to align with the community and other language servers (typescript,  java) in order to provide consistent refactoring experience across languages (vscode <https://code.visualstudio.com/docs/editor/refactoring> prefers to do extract with a default name and rename afterwards). Note that this patch aims to implement a generic mechanism to perform a chain of small refactorings (extract + rename is just one example), we still need this no match which way we're going to perform.

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list