[PATCH] D64753: [CrossTU][NFCI] Refactor loadExternalAST function

Tue Jul 30 01:27:37 PDT 2019

gamesh411 marked 2 inline comments as done.
gamesh411 added a comment.

Updated the revision.
I find this solution definitely more compact with responsibilities more separated. One more thing that comes to mind is that maybe the whole explicit passing of CTUDir and IndexName arguments is a bit verbose. What are your thoughts about these being injected earlier than the query operations (eg.: in getASTUnitForFunction and getFileForFunction)?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64753/new/

https://reviews.llvm.org/D64753