[PATCH] D65379: [analyzer][NFC] Refactoring BugReporter.cpp P2.: Clean up the construction of bug paths and finding a valid report

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 29 20:30:59 PDT 2019

xazax.hun accepted this revision.
xazax.hun added a comment.

Looks good, some nits inline. I agree with Artem, we should consider omitting the trimming and document how to get something similar if desired for debugging.

Just a random idea: maybe the original purpose of the trimming was to be able to reclaim parts of the exploded graph as soon as possible?

Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:2269
+  // Since the error node the BugReport is in to the original ExplodedGraph,
+  // we need to map it the one found in the trimmed graph.
+  using ReportNewNodePair = std::pair<BugReport *, const ExplodedNode *>;
This comment was really hard for me to understand, could you rephrase it?

Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:2305
+  BugPathGetter(const ExplodedGraph *OriginalGraph,
+           ArrayRef<BugReport *> &bugReports);
Formatting might be off here?

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list