[PATCH] D65333: [clangd] Refactor computation of extracted expr in ExtractVariable tweak. NFC

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 26 06:45:36 PDT 2019


sammccall created this revision.
sammccall added a reviewer: SureYeaah.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.

This takes this logic out of the Tweak class, and simplifies the signature of
the function where the main logic is.

The goal is to make it easier to turn into a loop like:

  for (current = N; current and current->parent are both expr; current = current->parent)
    if (suitable(current))
      return current;
  return null;


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D65333

Files:
  clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65333.211932.patch
Type: text/x-patch
Size: 6043 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190726/df251869/attachment.bin>


More information about the cfe-commits mailing list