[PATCH] D65250: [analyzer] exploded-graph-rewriter: Improve user-friendliness.

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 25 08:03:22 PDT 2019


NoQ added a comment.

In D65250#1600776 <https://reviews.llvm.org/D65250#1600776>, @grandinj wrote:

> There is no need to wrap SVG in HTML if you want to display it in a web-browser, you can just open the web-browser explicitly, they already support opening SVG, use something like
>
>   webbrowser.open_new(url)
>   
>
> i.e. https://docs.python.org/2/library/webbrowser.html


Mmm, interesting, maybe, but i don't see any obvious reasons to keep it in svg either. With html you can also save it and open up later without messing up your MIME associations, or even send it to others without having them mess with their MIME associations. With html you can also avoid the dark background glitch (the svg has limited size and would otherwise be displayed as a dark rectangle over a white background). Also it opens up opportunities for scripting, if we ever go that far (even if this gets more and more hacky). I guess i could do your suggestion under an `--svg` flag, but i'll prefer to have it off by default, because html is slightly better for most purposes. I guess it's worth it when the recipient doesn't trust html attachments (eg., for sending to the mailing lists).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65250/new/

https://reviews.llvm.org/D65250





More information about the cfe-commits mailing list