[PATCH] D65176: [NFC][clang] Refactor getCompilationPhases()+Types.def step 2.

Wed Jul 24 18:10:44 PDT 2019

plotfi marked 4 inline comments as done.
plotfi added inline comments.

================
Comment at: clang/include/clang/Driver/Types.def:39-45
+// Some of the options in Flags have been removed, so far those are:
+//  a - The type should only be assembled: Now, check that Phases contains
+//      phases::Assemble but not phases::Compile or phases::Backend.
+//  p - The type should only be precompiled: Now, check that Phases contains
+//      phases::Precompile but that Flags does not contain 'm'.
+//  m - Precompiling this type produces a module file: Now, check that
+//      isPrepeocessedModuleType.
----------------
aaron.ballman wrote:
> compnerd wrote:
> > aaron.ballman wrote:
> > > Why should we document the removed flags, since users cannot write them anyway?
> > Actually, that makes sense to me.  The reasoning for it (and the key thing to note about the documentation) is that it helps downstream forks as it indicates how to migrate.  Now, if you believe that this bit of functionality is unlikely to be used, thats a different story.  But, I don't think that it hurts to have the documentation in the commit message instead.
> Okay, that makes sense to me. Thank you for the explanation!
Yeah I just wanted a heads up for anyone downstream or anyone trying to update this table. Unfortunately I dont really understand the concept behind "user specified" types here. I assume it means  things like clang -xc++ or something like that. I will move this comment into the  commit message. Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65176/new/

https://reviews.llvm.org/D65176