[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 22 15:59:02 PDT 2019


aaron.ballman added a comment.

In D64666#1596619 <https://reviews.llvm.org/D64666#1596619>, @xbolva00 wrote:

> I think @jfb wanted to say that if we know we always lose the precision, we should warn even without -Wxyz, no?


Oh, good catch! I hadn't noticed that *both* diagnostics were `DefaultIgnore`. I can't think of a reason why we'd want the constant-checked version off by default because it seems like there's no way to have a false positive there.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64666/new/

https://reviews.llvm.org/D64666





More information about the cfe-commits mailing list