[clang-tools-extra] r366443 - [clangd] Disable DumpRecordLayout by default per https://bugs.llvm.org/show_bug.cgi?id=42670

[Hans Wennborg via cfe-commits]

Merged to the 9 branch in r366713.

On Thu, Jul 18, 2019 at 8:00 AM Sam McCall via cfe-commits
<cfe-commits at lists.llvm.org> wrote:
>
> Author: sammccall
> Date: Thu Jul 18 08:00:38 2019
> New Revision: 366443
>
> URL: http://llvm.org/viewvc/llvm-project?rev=366443&view=rev
> Log:
> [clangd] Disable DumpRecordLayout by default per https://bugs.llvm.org/show_bug.cgi?id=42670
>
> Modified:
>     clang-tools-extra/trunk/clangd/refactor/tweaks/DumpAST.cpp
>
> Modified: clang-tools-extra/trunk/clangd/refactor/tweaks/DumpAST.cpp
> URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clangd/refactor/tweaks/DumpAST.cpp?rev=366443&r1=366442&r2=366443&view=diff
> ==============================================================================
> --- clang-tools-extra/trunk/clangd/refactor/tweaks/DumpAST.cpp (original)
> +++ clang-tools-extra/trunk/clangd/refactor/tweaks/DumpAST.cpp Thu Jul 18 08:00:38 2019
> @@ -128,6 +128,11 @@ public:
>          TypeWithKeyword::getTagTypeKindName(Record->getTagKind()));
>    }
>    Intent intent() const override { return Info; }
> +  // FIXME: this is interesting to most users. However:
> +  //  - triggering is too broad (e.g. triggers on comments within a class)
> +  //  - showMessage has inconsistent UX (e.g. newlines are stripped in VSCode)
> +  //  - the output itself is a bit hard to decipher.
> +  bool hidden() const override { return true; }
>
>  private:
>    const RecordDecl *Record = nullptr;
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits